Great Pool Migration (prep) #1954
Conversation
There was a problem hiding this comment.
The 'legacy' approach unfortunately makes this very hard to review, since git treats this as LegacyBasePool being a spinoff of the new BasePool, with the old stuff added back, and the new BasePool being a spinoff of the old one, with the old stuff removed.
I suggest we don't rename the new one to BasePool yet, and only do that once the legacy one has been deleted from the repo. Instead of calling the old one legacy and new one base, we could keep the old one and call the new one NewBasePool. Alternatively, we could rename both - but I'm not sure this will fix the diff issues.
I tried it a couple ways; keeping the old one leads to a smaller diff at least. |
Description
In preparation for propagating the leaner, meaner BasePool of ManagedPool fame to the rest of the code base, move it from the /vendor directory inside pool-weighted, and rename the old one LegacyBasePool (similar to how we did it when switching from token to BPT protocol fees).
Type of change
Checklist:
(It got a bit confused in some places. And there is one extra line, to silence lint errors.)
master, or there's a description of how to mergeIssue Resolution
Advances #1953